Skip to content

fix(miner): drop stale ProcessEnv casts on resolveReplaySnapshotDbPath - #8768

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:fix/8642-replay-snapshot-resolver-casts-v2
Jul 26, 2026
Merged

fix(miner): drop stale ProcessEnv casts on resolveReplaySnapshotDbPath#8768
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:fix/8642-replay-snapshot-resolver-casts-v2

Conversation

@philluiz2323

@philluiz2323 philluiz2323 commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove stale not yet migrated comments and NodeJS.ProcessEnv casts around resolveReplaySnapshotDbPath in migrate-cli.ts and status.ts.
  • Call the resolver directly — its real type is already Record<string, string | undefined>.
  • Add a migrate open-adapter regression (test/unit/miner-migrate-cli.test.ts) so CI's backend path filter runs Build engine before typecheck (miner-lib-only PRs otherwise skip that step and fail tsc).

Closes #8642

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npx tsc -p packages/loopover-miner/tsconfig.json --noEmit (exit 0)
  • npx vitest run test/unit/miner-migrate-cli.test.ts -t "#8642" (1 passed)
  • Full suite left to CI
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable.

Notes

@philluiz2323
fix(miner): drop stale ProcessEnv casts on resolveReplaySnapshotDbPath
d22ae6e 
The resolver already types env as Record<string, string | undefined>; remove the outdated not-yet-migrated comments and casts at both migrate-cli and status call sites. Add a migrate open-adapter regression covering the uncasted path.

Closes JSONbored#8642
@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner July 26, 2026 03:28
@superagent-security

superagent-security Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (c8eed4c) to head (d22ae6e).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8768      +/-   ##
==========================================
- Coverage   93.80%   90.63%   -3.17%     
==========================================
  Files         797       98     -699     
  Lines       79493    22700   -56793     
  Branches    24085     3962   -20123     
==========================================
- Hits        74567    20575   -53992     
+ Misses       3555     1945    -1610     
+ Partials     1371      180    -1191
Flag Coverage Δ
backend 99.04% <ø> (+3.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-miner/lib/migrate-cli.ts 100.00% <ø> (ø)
packages/loopover-miner/lib/status.ts 98.83% <ø> (ø)

... and 699 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-26 03:33:04 UTC

3 files · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This PR removes a stale NodeJS.ProcessEnv cast and its accompanying comment around resolveReplaySnapshotDbPath in migrate-cli.ts and status.ts, calling the resolver directly with its real Record<string, string | undefined> signature. It adds a regression test in miner-migrate-cli.test.ts that opens a replay-snapshot store and confirms migrate reports it up-to-date without the cast, closing issue #8642. The change is small, well-scoped, and matches its stated intent exactly — a type-cleanliness fix plus a targeted test, not a functional behavior change.

Nits — 3 non-blocking
  • The PR pushes packages/loopover-miner/lib/status.ts to roughly 405 lines per the external size-smell note; not this diff's fault since it only removes 1 line there, but worth a follow-up split if the file keeps growing.
  • status.ts:399's storeIntegrityChecks still has the analogous stale-cast comment pattern for hasGitHubTokenSource (env as NodeJS.ProcessEnv) elsewhere in the file — worth a follow-up cleanup pass if that resolver's real type has also since been migrated.
  • Consider auditing the codebase for other 'not yet migrated'/ProcessEnv-cast comments (e.g. checkGitHubTokenPresent's hasGitHubTokenSource cast in status.ts) in a follow-up PR to fully close out this class of stale cast.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8642, #8755
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (2 linked issues).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1025 registered-repo PR(s), 601 merged, 126 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 1025 PR(s), 126 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff removes the stale 'not yet migrated' comments and NodeJS.ProcessEnv casts at both call sites in migrate-cli.ts and status.ts, calling resolveReplaySnapshotDbPath directly as required, and adds a regression test plus tsc validation confirming no new type error.

Review context
  • Author: philluiz2323
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
  • Official Gittensor activity: 1025 PR(s), 126 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 26, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 7b2104d into JSONbored:main Jul 26, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 26, 2026
Closed
7 tasks
This was referenced Jul 27, 2026
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@philluiz2323 philluiz2323

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(miner): remove stale 'not yet migrated' type-cast comments for resolveReplaySnapshotDbPath in migrate-cli.ts and status.ts

1 participant

@philluiz2323